chore: use oxfmt sortImports - #23319
Merged
Merged
Conversation
sapphi-red
force-pushed
the
chore/use-oxfmt-sortimports
branch
from
August 21, 2026 02:41
a7f63ee to
9b5a168
Compare
sapphi-red
force-pushed
the
chore/use-oxfmt-sortimports
branch
from
August 21, 2026 11:42
9b5a168 to
523d767
Compare
Member
Author
|
After merging we should add the commit to https://github.com/vitejs/vite/blob/main/.git-blame-ignore-revs |
sapphi-red
marked this pull request as ready for review
August 21, 2026 12:00
bluwy
approved these changes
Aug 21, 2026
btea
approved these changes
Aug 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
import-x/orderrule is not implemented in oxlint as a native rule and oxfmt hassortImportsoption that has similar functionality. This PR migrates it so that it is easier to migrate to oxlint later. It should be more performant as well.sortImportsseems to sort the order within the groups. The original eslint-plugin-perfectionist/sort-imports hastypeoption which can disable this, but it seems oxfmt does not support that option. I think it's nice to have this sorting.